fix: connect skill adapter lifecycle events to runtime event system#545
Merged
fix: connect skill adapter lifecycle events to runtime event system#545
Conversation
Replace unused runtimeEventListener with onLifecycleEvent callback, thread it through all factory contexts, and bridge adapter-level lifecycle events to RuntimeEvents in CoordinatorExecutor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
FL4TLiN3
added a commit
that referenced
this pull request
Feb 16, 2026
With real-time lifecycle event emission (from #545), the gap between base's skillConnected and startRun now includes other adapter setup time. Increase threshold from 50ms to 200ms to account for this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtimeEventListeneroption withonLifecycleEvent(adapter-level callback) inSkillManagerOptionsonLifecycleEventthrough all factory contexts (fromExpert,fromLockfile,addSkill,addDelegate)_connectingEventData()hook toSkillAdapterbase class; override inMcpSkillAdapterto providecommand/argsorendpointconnectDurationMs/spawnDurationMstiming data inconnectedeventsLockfileSkillAdapterfrom emitting spurious lifecycle events (only the real adapter emits)emitSkillConnectedEvents()with real-timecreateLifecycleEventBridge()inCoordinatorExecutorthat bridgesconnecting→skillStarting,connected→skillConnected,stderr→skillStderr,disconnected→skillDisconnectedTest plan
pnpm typecheck— passespnpm test— 1079 tests pass (92 files)pnpm test:e2e— 78 tests pass (19 files)pnpm build— passespnpm format-and-lint— passes (no new warnings)pnpm run validate:changeset— passes🤖 Generated with Claude Code